v2.0: replay: extend last fec set check for 32+ retransmitter signed shreds (backport of #2101)#2192
Merged
AshwinSekar merged 1 commit intov2.0from Aug 28, 2024
Merged
Conversation
Author
|
Cherry-pick of 93edb65 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
This is the last piece of the duplicate block detection effort, which we hope to rollout in 2.x. |
|
are we planning to bp #1840 |
behzadnouri
force-pushed
the
mergify/bp/v2.0/pr-2101
branch
from
ccb0a09 to
2075492
Compare
behzadnouri
previously approved these changes
Aug 3, 2024
|
I think this PR is ready for approval/merge. |
|
@AshwinSekar can you resolve the merge conflict? |
AshwinSekar
dismissed stale reviews from bw-solana and behzadnouri
via
e37ff07
AshwinSekar
force-pushed
the
mergify/bp/v2.0/pr-2101
branch
from
2075492 to
e37ff07
Compare
|
f now downstream is busted |
AshwinSekar
force-pushed
the
mergify/bp/v2.0/pr-2101
branch
from
e37ff07 to
fe4c2b3
Compare
behzadnouri
previously approved these changes
Aug 19, 2024
bw-solana
previously approved these changes
Aug 20, 2024
…#2101) * replay: extend last fec set check for 32+ retransmitter signed shreds * pr feedback: use separate feature flag * pr feedback: is_retransmitter_signed -> is_retransmitter_signed_variant, false for legacy * pr feedback: update doc comment fail -> error * pr feedback: hash -> bank_hash for report metrics * refactor metrics inside blockstore fn, return block_id for future use * pr feedback: gate metrics reporting * pr feedback: do not distinguish impossible combos, simplify check code * pr feedback: remove report_metrics helper fn * pr feedback: remove metric * pr feedback: block_id -> last_fec_set_merkle_root
AshwinSekar
dismissed stale reviews from bw-solana and behzadnouri
via
72293fc
AshwinSekar
force-pushed
the
mergify/bp/v2.0/pr-2101
branch
from
fe4c2b3 to
72293fc
Compare
bw-solana
approved these changes
Aug 26, 2024
behzadnouri
approved these changes
Aug 26, 2024
t-nelson
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the feature flag is turned on, we need to verify that the last fec set uses the new shred format.
Because the last fec set is not known when receiving shreds, and the new shred format is only used for the last set, we cannot perform this check until replay has completed.
Summary of Changes
Extend the check which compares the merkle roots of the last fec set to additionally check that they are all of the retransmitter shred variant.
This is an automatic backport of pull request #2101 done by [Mergify](https://mergify.com).